vipin1006 / eHire

eHire Project Repository
3 stars 4 forks source link

Candidate: Change the error message, etc. #13

Closed srilatha-sriram closed 8 years ago

srilatha-sriram commented 8 years ago

Issue 1. Change "Please fill the existing candidate details before adding a new candidate" TO "Please fill ALL the details of the selected candidate before adding a new candidate"

Issue 2. Delete button is still enabled soon after deleting a candidate even if no other candidate is selected. It should be disabled when no other candidate is selected.

Issue 3. Add tool tips for + and - buttons of candidate.

Issue 4: When a date is selected, i.e. when candidate details are listed, change the window title to 'List of Candidates for <mm/dd/yyyy>

PratibhaSawargi commented 8 years ago

I will work on it.

PratibhaSawargi commented 8 years ago

Issue resolved,Please verify.

srilatha-sriram commented 8 years ago

4 issues were reported. Can u clarify which issue is resolved. If all are done, you should clearly mention that.

PratibhaSawargi commented 8 years ago

Issue 1,issue 3,issue 4 are resolved. Issue 2 i will fix it soon.

srilatha-sriram commented 8 years ago

You should assign to me as request for verification only after all the issues are resolved.

PratibhaSawargi commented 8 years ago

Okay. I will take care.

PratibhaSawargi commented 8 years ago

Issue 1 : Changed the informativeText. Issue 2 : Delete button is disabled when no other candidate is selected. Issue 3. Added tool tips for + and - buttons of candidate. Issue 4: When a date is selected, changed the window title to 'List of Candidates. All issues are fixed. Please verify and let me know if any changes required.

srilatha-sriram commented 8 years ago

Issue 2 & 3 are still not fixed. Please make sure you CHECK/TEST THOROUGHLY before sending for verification.

PratibhaSawargi commented 8 years ago

Yesterday itself i have resolved issue2 and issue 3. Because of some conflict that is not reflecting in code.Now i am checking.

PratibhaSawargi commented 8 years ago

Issue 2 : Delete button is disabled when no other candidate is selected in tableview.

srilatha-sriram commented 8 years ago

Verified. Closing.

PratibhaSawargi commented 8 years ago

In tableview when we add a empty candidate, after selecting that candidate it was taking to feedback controller.This issue is now fixed.