vipm-io / caraya

Assertion and unit test framework for LabVIEW
Other
59 stars 33 forks source link

Time attribute contains element tags in JUnit report #178

Closed logmanoriginal closed 1 year ago

logmanoriginal commented 1 year ago

Using Caraya 1.4.1, time attribute values for test suites and test cases in JUnit reports contain element tags, which breaks parsers.

Actual

<testsuite time="<time>0.123</time>">
<testcase time="<time>0.123</time>">

Expected

<testsuite time="0.123">
<testcase time="0.123">

Here is a test case: Time attribute should not contain element tags

francois-normandin commented 1 year ago

Confirmed.

Since XML is not forcing dot-notation, but can support locale-specific numbers. I made your test compatible with locale settings for both comma and dot separated values. (Note that the use can set the desired locale strategy in the report class)

image

The following snippet (set as value) has been inserted in the Report.JUnit routine where time was concerned.

image

francois-normandin commented 1 year ago

image

francois-normandin commented 1 year ago

Released with a fix in 1.4.2