search

vipmax / edgo

Yet another console text editor, but with lsp support
MIT License
32 stars 0 forks source link

Edgo still incorrectly marks 1st line as a test #3

Open qwertzy-antonio-godinho opened 1 year ago

qwertzy-antonio-godinho commented 1 year ago

Hi, thank you for looking at this, but there is still one instance where it wrongly IDs a test where there is none, line 1. It seems that for some reason edgo always marks the first line as a test. It can be also seen on your screen shot in #2.

vipmax commented 1 year ago

Hi, this is fine, cause it is necessary for python file execution

qwertzy-antonio-godinho commented 1 year ago

You mean by default edgo will always mark the first line on any python file as a test, even if there is no shebang in the file? Or the line is empty?

vipmax commented 1 year ago

For some languages, it is possible to execute a file using a single command. Edgo adds a green button and spawns some process depending on the language when clicked. For example go, python, js, ts, java, bash. Shebang is not supported yet, but in the future, of course, it will be.

qwertzy-antonio-godinho commented 1 year ago

For some languages, it is possible to execute a file using a single command. Edgo adds a green button and spawns some process depending on the language when clicked. For example go, python, js, ts, java, bash. Shebang is not supported yet, but in the future, of course, it will be.

Would you consider then making this play icon having a different colour to differentiate from execution of tests? Either way this issue can be closed