vippsas / vipps-recurring-woocommerce

Vipps Recurring payments for WooCommerce
GNU Affero General Public License v3.0
6 stars 4 forks source link

Possible temporary failure edge case with no automatic recovery #19

Closed Marcuzz closed 4 years ago

Marcuzz commented 4 years ago

I noticed an order that had the following postmeta:

_vipps_recurring_captured: 1

and

_vipps_recurring_pending_charge: 1
_vipps_recurring_locked_for_update: 1

This means the charge was captured, but it failed before it was able to set pending_charge to 0 and update the order status. Perhaps a temporary failure with a certain API request?

This put the order in a state where it was not automatically recoverable and manual intervention was needed.

Marcuzz commented 4 years ago

Solution: Make a time based lock instead

Marcuzz commented 4 years ago

Fixed in 1.3.10