danielcherubini
commented
2 years ago Yeah please if you want to do it that would be great.
On Wed, 20 Apr 2022, 16:28 Marcus, @.***> wrote:
@.**** requested changes on this pull request.
I'm not a fan of adding compatibility code directly in the code like this. Instead, we should be using filters and override the specific functionality based on the existence of WCS_ATT_Cart in wc-vipps-recurring-compatibility.php https://github.com/vippsas/vipps-recurring-woocommerce/blob/master/includes/wc-vipps-recurring-compatibility.php
I can of course do this for you now that I'm back 😄
— Reply to this email directly, view it on GitHub https://github.com/vippsas/vipps-recurring-woocommerce/pull/59#pullrequestreview-947265503, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADBQ4MJQSRZNBSXATAARH3VGAH7ZANCNFSM5TKQNEOA . You are receiving this because you authored the thread.Message ID: @.***>
This adds support for issue #58
Tested locally, let me know if there's any issues.