search

vipsoft / JiraExtension

Load Features for Behat from Jira issues
MIT License
22 stars 18 forks source link

Suggested Name Change? #15

Closed srizzling closed 10 years ago

srizzling commented 10 years ago

Currently working on implementing this feature: https://github.com/vipsoft/JiraExtension/issues/13

I have completed a working prototype, will need to refactor and write up some unit tests before I can push it back to open source.

Currently there is a AfterScenarioListener.php file. I was hoping to suggest a name change, to JiraServiceListener.php which will allow for other hooks such as AfterSuite. This is because I do not want to push per scenario basis but after the whole suite is finished for performance reasons.

And before I made a change to architecture of the plugin I was going to ask if it were a good idea.

robocoder commented 10 years ago

Sure, let's rename. IIRC I used HookListener in another extension, so for consistency, that would be my preference.

srizzling commented 10 years ago

Sounds Good! I will make a separate pull request for the name change.