search

vipx / google-guice

Automatically exported from code.google.com/p/google-guice
Apache License 2.0
0 stars 0 forks source link

binder.install() should possibly be safe from RuntimeExceptions #33

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
if anything is thrown out of Module.configure(), the binder might want to
catch that and record it with addError() instead of bombing out completely.
 However, this may not be so great either as there could be a ripple effect
of other errors that happen only because of the missing bindings from this
module.

Original issue reported on code.google.com by kevin...@gmail.com on 27 Feb 2007 at 7:59

GoogleCodeExporter commented 9 years ago

Original comment by kevin...@gmail.com on 27 Feb 2007 at 8:04

GoogleCodeExporter commented 9 years ago

Original comment by kevin...@gmail.com on 13 Mar 2007 at 1:13

GoogleCodeExporter commented 9 years ago 
some concern about collateral errors if we continue.  But... is it worse to show
people errors that aren't really errors, or to not show them errors that really 
are?
 Everyone is well accustomed to collateral damage from javac, their junit tests, etc.

Original comment by kevin...@gmail.com on 19 Mar 2007 at 6:13

GoogleCodeExporter commented 9 years ago 
Presumably some errors can be reporting even assuming that there are more 
modules to
add that we don't know about (open-world) while others assume we have all the
information (closed world).  If an module bombs out, it seems like we should 
still go
on and do error-checking under the open-world assumption.

If there were a way to do this, we could also check subsets of modules for
consistency; that is, check whether any single module is self-consistent, or 
whether
any two modules are compatible.

Original comment by bslesinsky on 8 Jul 2007 at 12:17

GoogleCodeExporter commented 9 years ago

Original comment by limpbizkit on 30 May 2008 at 6:52

GoogleCodeExporter commented 9 years ago 
We can simply call binder.addError() if installing a Module bombs out.

Original comment by limpbizkit on 25 Jun 2008 at 6:38

GoogleCodeExporter commented 9 years ago 
Jacob Hite submitted a fix. Thanks!

Original comment by limpbizkit on 8 Jul 2008 at 12:27