search

vipx / google-guice

Automatically exported from code.google.com/p/google-guice
Apache License 2.0
0 stars 0 forks source link

Simplify build scripts by removing unnecessary jarjar invocations #719

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
Issue 709 is a pre-req for this: once guava has been pulled-out as a dependency 
then the build can be simplified since only the core needs to have jarjar 
applied.

Original issue reported on code.google.com by mccu...@gmail.com on 31 Jul 2012 at 10:06

GoogleCodeExporter commented 9 years ago 
Candidate patch, tested locally

Original comment by mccu...@gmail.com on 31 Jul 2012 at 10:08

Attachments:

GoogleCodeExporter commented 9 years ago 
Latest patch against HEAD

Original comment by mccu...@gmail.com on 9 Dec 2013 at 6:04

Attachments:

GoogleCodeExporter commented 9 years ago 
I'm less keen on exposing the asm & cglib dependencies, but could be convinced 
about the guava one.

Original comment by sberlin on 9 Dec 2013 at 6:40

GoogleCodeExporter commented 9 years ago 
This patch doesn't expose the asm or cglib dependencies, it just cleans up and 
simplifies the jarjar invocations.

Once the patch in issue 709 is applied the extensions can build against the 
final jarjar'd binary which means there is no need for the intermediate 
'with-deps' phase. Instead the embedding of asm and cglib is performed for the 
core build only, and the extensions build against that binary.

Original comment by mccu...@gmail.com on 9 Dec 2013 at 6:44

GoogleCodeExporter commented 9 years ago 
Ah ok, I was misreading.  Thanks for clarifying!

Original comment by sberlin on 9 Dec 2013 at 6:46

GoogleCodeExporter commented 9 years ago 
Btw CGLIB 3.1 is now available on central, so I've updated and cleaned up the 
patches accordingly:

https://raw.github.com/sonatype/sisu-guice/master/PATCHES/GUICE_709_externalize_
guava_dependency.patch
https://raw.github.com/sonatype/sisu-guice/master/PATCHES/GUICE_719_simplify_jar
jar_build_setup.patch

Original comment by mccu...@gmail.com on 10 Dec 2013 at 3:20

GoogleCodeExporter commented 9 years ago 
Makes more sense to merge this into a single patch along with the changes for 
issue 709

Original comment by mccu...@gmail.com on 3 Jan 2014 at 1:00