Grapher generates dot files with syntax errors

[GoogleCodeExporter]

Description of the issue:

Grapher generates dot files with syntax errors:

Warning: graph.dot:3: syntax error in line 3 near ','

Steps to reproduce:
1. Follow the example https://code.google.com/p/google-guice/wiki/Grapher
2. Run the code
3. Try to generate a diagram using dot, e.g.

  dot -Tsvg graph.dot > graph.svg

Original issue reported on code.google.com by stant...@gmail.com on 19 Jun 2013 at 7:54

[GoogleCodeExporter]

Patches are gladly accepted!

Original comment by sberlin on 5 Dec 2013 at 10:51

[GoogleCodeExporter]

I get the same error - any clue on how to get a correct graph generated?

Original comment by scott.ma...@gmail.com on 20 Dec 2013 at 4:50

[GoogleCodeExporter]

This is what I did to get it to work with guice 4.x:  
http://stackoverflow.com/questions/9301007/is-there-any-way-to-get-guice-grapher
-to-work/20790253#20790253

Original comment by scot.h...@gmail.com on 26 Dec 2013 at 7:44

[GoogleCodeExporter]

If there's something we can change in the code itself to fix this, please 
attach a patch here.  Thanks!

Original comment by sberlin on 26 Dec 2013 at 7:48

[GoogleCodeExporter]

The attached patch is all that's necessary to get a simple example working for 
me.  I wasn't sure how to right a good test that captured this fix.  Perhaps an 
integration test should actually invoke dot to check the syntax of a generated 
file?

Original comment by tavianator@gmail.com on 6 Jan 2014 at 8:04

Attachments:

• 0001-extensions-grapher-Fix-a-syntax-error-in-the-generat.patch

[GoogleCodeExporter]

Ping?

Original comment by tavianator@gmail.com on 25 Mar 2014 at 5:53

[GoogleCodeExporter]

Fixed by r=647b24f7f1b5.

Original comment by sberlin on 10 Apr 2014 at 11:28

• Changed state: Fixed