search

vipyrsec / dragonfly-mainframe

The mainframe for Dragonfly
https://docs.vipyrsec.com/dragonfly-mainframe/
MIT License
4 stars 2 forks source link

Forward reports to dragonfly-reporter #201

Closed jonathan-d-zhang closed 3 months ago

jonathan-d-zhang commented 4 months ago

This PR should not be merged without a corresponding PR on the bot

Robin5605 commented 4 months ago

Re: this comment

It's been discussed on Discord - but it seems like falling back to email is not desirable, and sending emails should be an explicit function rather than implicitly done on failure. The reporter service will most likely end up with two routes, one for the observation API and one for the email. This PR will have to be stalled until that's complete.

Blocked by https://github.com/vipyrsec/dragonfly-reporter/pull/10

Robin5605 commented 4 months ago

This PR should be merged at the same time as https://github.com/vipyrsec/bot/issues/223

Robin5605 commented 4 months ago

Actually, I believe this can be merged. This PR is backwards compatible and will not break the bot if it were to be merged and deployed.