bug fix: `alwaysRenderIn` setting may be outside of right sidebar panel

vipzhicheng / logseq-plugin-block-calendar

A block calendar for Logseq.

MIT License

37 stars 13 forks source link

bug fix: `alwaysRenderIn` setting may be outside of right sidebar panel #26

Closed stdword closed 1 year ago

stdword commented 1 year ago

A bit of refactoring to prevent future bugs like described in this comment.

No new functionality here: just fix a bug.

vipzhicheng commented 1 year ago

Sorry, I just change it back, to see if it can solve your issue. This PR changed so much, and I checked it out on my local, it has bug in the sidebar calendar case. So the PR can not be merged.

stdword commented 1 year ago

Yes, this is my fault: I didn't setup dev env properly.

Now I've tested ALL the cases with widget and fix lots of bugs here. Closing this PR.