search

vipzhicheng / logseq-plugin-lock

Lock each Logseq block in even different password.
MIT License
30 stars 2 forks source link

Use case for viewing, not just copy to clipboard #5

Open astubbs opened 1 year ago

astubbs commented 1 year ago

What about the situation where you have "private" notes, as opposed to passwords? In which case, you want the original text to display. Maybe until a timeout, or until the window losses focus? I get that the plugin seems to have been developed for passwords - but private notes is also I think a big use case for something like this. Thoughts?

Seems from this issue, you want to keep the plugin use case quite narrow, fair enough. Maybe rename it to plugin-passwords-lock?

https://github.com/vipzhicheng/logseq-plugin-lock/issues/3#issuecomment-1048405529

lukas-mertens commented 1 year ago

@vipzhicheng +1 on this, I would also enjoy a version of the plugin which features a viewing experience, especially if it was your vim-editor ;) I think this would combine greatly

vipzhicheng commented 1 year ago

It's hard to render block in a plugin as Logseq did, so if you want original text, it can only show in a text area in pure text. Is that OK?

lukas-mertens commented 1 year ago

I think that would already be sufficient for most usecases. I think it would be great if you could just show it in the vim-editor from your other plugin, it includes syntax highlighting for markdown for example so that would be ideal for me. Maybe you could for example do it, that when you press the same keyboard combination (I think it was cmd+shift+e) it just shows the password-prompt first and the opens the editor. For non-vim-users, if they don't have your vim-plugin installed, just show it in the same editor, but without vim keybindings and a "close"-button or something like that, which saves changes as well. I don't know if it is possible to cross-communicate between plugins like that but I would actually put a bounty of at least 20$ on this feature, if you would implement it using the vim-editor