search

vipzhicheng / logseq-plugin-mark-map

This is a plugin for https://github.com/logseq/logseq to provide mindmap support based on https://github.com/markmap/markmap.
282 stars 7 forks source link

shortcut ctrl-m conflicts on windows #58

Closed ndc33 closed 1 year ago

ndc33 commented 1 year ago

Hi, CTRL m on windows is to minimize (a requirement when using full screen mode. Perhaps provide an option to disable all markmap shortcuts?

vipzhicheng commented 1 year ago

It's awkward that shortcuts always conflict with System or other plugins. Markmap provides a settings file to adjust shortcuts, the entry is marked in the below screenshot.

image

There is no UI for this. please have a try.

pasoevi commented 1 year ago

For me, it seems to conflict with its own shortcuts: Screenshot 2023-03-19 170516

As a result, the plugin doesn't activate after installing and doesn't show up in the Plugin toggle menu in the toolbar.

vipzhicheng commented 1 year ago

OK, as this issue happened, I want to disable all of the keybindings by default, but let users decide and set them in the settings file. What about this way to change?

pasoevi commented 1 year ago

I tried removing all keybindings, and I no longer get the above errors, but the plugin still doesn't work.

I installed the plugin both, on Mac and Windows (I even tried with fresh installation of LogSeq in both, to make sure my config isn't breaking the plugin) and it gives the above errors in both platforms and I cannot make it work even after removing all keybindings.

ndc33 commented 1 year ago

Hi, just to say I would prefer an option to have NO shortcuts (shortcuts are only of benefit when long time spent immersed in an environment). This package has so many bindings it 'stomps' on everything else.

pasoevi commented 1 year ago

Sorry, my bad. The plugin is actually (it is actually awesome!) loading after getting rid of key binding conflicts.