search

viralogic / py-enumerable

A Python module used for interacting with collections of objects using LINQ syntax
MIT License
187 stars 24 forks source link

Consider typing #62

Open cleoold opened 3 years ago

cleoold commented 3 years ago

Adding type annotations to the library would be helpful for those into type checking. This can avoid type errors.

I can create separate PRs for this as it is simple enough :-) Do you think this is a good idea?

cleoold commented 3 years ago

Because I couldn't get the author to reply me :-| I wrapped up my own library that has similar usage to py-enumerable, except it has fully typed interface and really lazy evaluations (e.g. py-enumerable does not support infinite streams).

viralogic commented 3 years ago

@cleoold Apologies for this. I never received a notification that this issue was even created and just noticed this today.

I think this is an acceptable request given that py-enumerable is really only supporting 3.9, 3.8, 3.7 now and typing is already baked in these Python versions. I actually was thinking of doing this myself already actually. I will have a look at your work and attempt to incorporate into py-enumerable.

mokeyish commented 3 years ago

https://github.com/jakkes/python-linq has typing.