search

virango / Toaster

Editor and remote control for Kemper profiling amplifier
23 stars 6 forks source link

Toaster shows value of 0.0 on EQ, but LEDS on knobs indicate -5.0 #9

Closed skoczy closed 7 years ago

skoczy commented 8 years ago

Windows 7-32bit, Toaster 1.0.100 ALPHA

Toaster, while started shows 0.0 on EQ knobs but LEDS are far left to -5.0 image

After turning knobs full left by mouse, Toaster now shows -5.0 and it shows 0.0 at noon (top LED) image

skoczy commented 8 years ago

Now toaster shows 0.0 when top LED is lit. image

jsharpe commented 7 years ago

I have a fix for this issue, I will post a pull request in a few days to fix this.

virango commented 7 years ago

@jsharpe: You can reproduce this one? Never occured on my systems. I thought this was a local midi communication problem.

jsharpe commented 7 years ago

Yes, when my midi device is set to the apple network midi interface and hence its not received any data. The issue is basically a missing redraw request from the initial data. Issue #14 is very similar, I know why thats occurring but haven't worked out a fix yet. Will probably address both issues at the same time.

virango commented 7 years ago

I'm not sure if you are aware of the fact that the editor strongly relies on a working 2-way midi communication. After starting, it connects to and requests data from the profiler. Connecting means: open midi in and out ports and send the connection beacon. The beacon is sent periodically every 5 secs and while it is sent the profiler sends some data (e.g. state of the stomp boxes etc.). I didn't see the necessity to sync the knob graphic with it's initial value, both are updated after the requested data is received from profiler. But that's not a big issue. Skoczys problem is another story. What you can deduce from his snapshots is that the communication worked just partly and not all requested parameters were received (the name of the rig, state and type of the stomp were; gain, equalizer values were not).

jsharpe commented 7 years ago

I agree that #8 looks to be due to flaky midi connections. I think getting the knob to sync visually to the internal state is a good idea for the future as it facilitates moving towards being able to do offline editing.

virango commented 7 years ago

Agreed.