vircadia / vircadia-builder

Builds Vircadia's native Interface and Domain server ("Project Athena") on Linux.
GNU General Public License v3.0
20 stars 37 forks source link

vircadia-builder fails if git repo does not have any tags #83

Closed JulianGro closed 2 years ago

JulianGro commented 2 years ago
motofckr9k@motofckr9k-VirtualBox:~/git/vircadia-builder$ ./vircadia-builder --make-appimage -r https://github.com/odysseus654/vircadia.git -t feature/scripting
Checking how many cores to use for building Vircadia... 10 cores
Checking how many cores to use for building Qt... 10 cores
Detecting desktop location... /home/motofckr9k/Desktop
Detecting distribution... Ubuntu 18.04.6 LTS (ubuntu-18.04)
Getting the package list... done.
Checking Qt availability... binary Qt package available.
Checking if any packages need installing... no.
Checking for NPM... Found installed, all good.

Everything seems to be in order. I am going to ask you some questions now.
The defaults should be just fine. Simply press ENTER to accept the suggested
value.

By default, the code will be compiled to target your specific hardware.
If you are going to deploy this build on another machine, choose the 'compatible'
optimization level. It will be automatically selected by default for AppImage builds.

Git repository             : https://github.com/odysseus654/vircadia.git
Git tag                    : feature/scripting
Release type               : DEV
Release number             : PR1200_e407507
Build number               : PR1200_e407507
Installation dir           : /home/motofckr9k/Vircadia
CPU cores to use for Vircadia: 10
CPU cores to use for Qt5   : 10
Optimization level (compatible, native, noneor help): compatible

If the above is okay, say 'yes' to begin installation: yes

############################################################
# Starting installation
############################################################

Getting source from git https://github.com/odysseus654/vircadia.git (feature/scripting)...
Checking /home/motofckr9k/Vircadia/source... ok.
Cloning into '/home/motofckr9k/Vircadia/source'...
remote: Enumerating objects: 671062, done.        
remote: Counting objects: 100% (7242/7242), done.        
remote: Compressing objects: 100% (3129/3129), done.        
remote: Total 671062 (delta 4346), reused 6578 (delta 3970), pack-reused 663820        
Receiving objects: 100% (671062/671062), 1.02 GiB | 8.21 MiB/s, done.
Resolving deltas: 100% (486047/486047), done.
Checking out files: 100% (7833/7833), done.
fatal: No names found, cannot describe anything.
To aid with debugging, please re-run with the --collect-info argument.

Fatal error:
Command 'git -C /home/motofckr9k/Vircadia/source describe --tags' exited with value 128

Logs have been collected in vircadia-builder-error-2021-11-04_T22_55_56.tar.gz
Please notify Dale Glass#8576 on Discord of this problem.
motofckr9k@motofckr9k-VirtualBox:~/git/vircadia-builder$

My understanding is that it is looking for tags (not branches), but since there is none, it thinks this is fatal and exits.

daleglass commented 2 years ago

Yeah, it's doing that to try to generate a version number. I might just rip that out, because I think it may not be an useful idea after all.

JulianGro commented 2 years ago

I like it using folders for tags, but I guess it shouldn't be a requirement.