vircadia / vircadia-native-core

Vircadia open source agent-based metaverse ecosystem.
https://vircadia.com/
Other
532 stars 175 forks source link

AccountInfo.bin still used even if we are disconnected. #1262

Open AleziaKurdis opened 3 years ago

AleziaKurdis commented 3 years ago

If you are disconnected from the metaverse. and still have a valide "AccountInfo.bin" file in Roaming Interface (for any reasons.. like a crash) You are considered not logged in by interface, but the permission check keep considering you as still connected. and you might be allowed to work on your domain as not being connected.

At startup. we should at least check if we can trust the current AccountInfo.bin by checking if the user is connected or not with the metaverse.

I guess it can be tested by copying the "AccountInfo.bin" file while you are connected, then logged out and restart with that copy of the file. You will observe weird cases with permissions.

AleziaKurdis commented 3 years ago

The natural way to get this is possibly this sequence of events: While you are logged in, you craches for any reasons.. (so you have quit without logging out) Then the Metaverse server get restarted (which kill all the session) Then you start interface (as no more "logged in"), but you still have the "AccountInfo.bin" and permission check consider you as connected.