vircadia / vircadia-native-core

Vircadia open source agent-based metaverse ecosystem.
https://vircadia.com/
Other
531 stars 175 forks source link

Entities without a existing parent entity will still load but not visible #227

Open thoys opened 4 years ago

thoys commented 4 years ago

Parented entities without an existing parent entity will still load but not visible.

E.g.

To reproduce, edit your models.json.gz file to have an entity with a parentID which is not an id that exists. You could either have a particle or a sound playing entity to get a good result.

ctrlaltdavid commented 4 years ago

This may have been fixed in HiFi master - PR 16361 ~14 Nov 2019.

two-one-five commented 4 years ago

Was that PR merged or will I need to retrieve it from the repo for K3?

two-one-five commented 4 years ago

Long term... @HifiExperiments and I concluded that this might be a good route:

  1. Don't let entities that don't have existing parents do anything on load. (such as render or create sound)
  2. When you export a domain, wipe all invalidly parented entities so you don't eternally carry around cruft from deployment to deployment.
ctrlaltdavid commented 4 years ago

This problem could bear retesting now that HiFi master has been merged into the Vircadia code.

daleglass commented 4 years ago

It's possible the master merge made changes in this regard, should be retested

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 3 years ago

Hello! Is this still an issue?