vircon32 / ComputerSoftware

General repository for all software (emulators, dev tools, etc) related to Vircon32 but not running on console itself
http://www.vircon32.com
Other
32 stars 3 forks source link

CMake improvements for linux #4

Closed Tardo closed 2 years ago

Tardo commented 2 years ago
Tardo commented 2 years ago

ping @DeathKhan for review

DeathKhan commented 2 years ago

Looks good to me, I’ll give it a run later today to see if it all builds properly, I prefer your dynamic implementation.

vircon32 commented 2 years ago

I just tested the build in Windows and Ubuntu and it was successful. When I saw the changes in the cmake script I first thought that I would be asked the added questions "install desktop files?" or "install desktop files globally?". But that never happened, so I guess those must be set as variables beforehand, am I right?