vire / jest-vue-preprocessor

Preprocessor that allows importing of .vue files in jest tests
MIT License
130 stars 27 forks source link

Changelog should highlight breaking change about node engine #68

Closed ematipico closed 4 years ago

ematipico commented 6 years ago

I'm submitting a ... (check one with "x") Missing information in the changelog

[ X] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request

Current behavior

N/A Expected behavior

N/A Minimal reproduction of the problem with instructions N/A What is the motivation / use case for changing the behavior?

I updated to the latest and my CI system broke because their node version is not supported. I think that in changelog the library should state that node version lesser than 8.9 are not supported anymore.

Please tell us about your environment:

N/A

vire commented 6 years ago

@ematipico thanks for pointing out, I had some issues with generating proper conventional changelog :( Mostly the commit wasn't tagged as breaking in commitizen...

ematipico commented 6 years ago

Oh gosh, I get it now