search

viresh-ratnakar / exolve

Online interactive crossword software in JavaScript
MIT License
73 stars 15 forks source link

Some (desktop) keyboard navigation feature requests #10

Closed Antagony1060 closed 4 years ago

Antagony1060 commented 4 years ago

  1. Could it have tab and shift-tab to jump between next/previous clues, as ordered in the clue lists. They do this with the Guardian crossword and it's easily the best way to navigate their grids, I find.

  2. Could the automatic jump from the end of a light to the next open square on the row, be optional? I personally find it more annoying than useful and have to navigate back to the previous light most times.

  3. Last but not least: it could do with a simple keyboard method to change direction. From 1a in your Fifteen Puzzles grid for example, getting to 1d is not straightforward without the mouse. The fewest number of key presses I could manage it in was 9! Now you might ask, "what's wrong with using the mouse?" Well nothing, except that filling a crossword is typing, which most people use both hands for, so having to switch to the mouse, even if infrequently, can be a distraction/annoyance. Since the 'Enter' key isn't usually used for any purpose in filling crosswords, might I suggest using that?

viresh-ratnakar commented 4 years ago

All excellent suggestions, thanks! I'll try to implement asap.

Antagony1060 commented 4 years ago

That's great, thanks!

I have to say I'm very impressed by the flexibility of the clue list formatting. I've tried out all sorts of things and most of them just worked. One of our puzzles even has a multi-line clue, which I thought would probably have to go on one line, but I stuck in some break tags anyway, more in hope than expectation, and bam! Not only did it work right away, it was properly indented to boot! Again, great job! And thank you for making it open source.

viresh-ratnakar commented 4 years ago

Thanks -- stuff "just working" naturally is indeed the happiest kind of working, something to always strive for!

I've checked in v0.24 which provides the navigation features requested. Please check when you get the chance.

Antagony1060 commented 4 years ago

Wow, that was a lot quicker than I expected, thank you! All tested, approved – nice touch with the hidden 'controls' panel, by the way :+1: – and installed, so I'll close this issue off.

Antagony1060 commented 4 years ago

You know when I said that multi-line clue (2 down) just worked, well I kinda lied! :\^) I hadn't noticed that selecting the clue results in the current-clue box obscuring part of the grid, including the first letter of the clue's own light.

Any chance of a fix? I would suggest just replacing the line breaks with spaces, but you may prefer to reposition things so I'll leave that to your discretion.

viresh-ratnakar commented 4 years ago

Fixed in v0.28: I now replace
tags in clues with "/" for rendering in the "current clue" strip.

Antagony1060 commented 4 years ago

I'm happy with that, thanks!

viresh-ratnakar commented 4 years ago

Ah, I should have added spaces around the "/" (will fix in the next version). You can work around for now by putting spaces around your
tags, if you like.

On Tue, Oct 8, 2019 at 2:03 AM Antagony1060 notifications@github.com wrote:

Closed #10 https://github.com/viresh-ratnakar/exolve/issues/10.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/viresh-ratnakar/exolve/issues/10?email_source=notifications&email_token=AJQ562A4KPYBCZWXNGSRT3TQNREHTA5CNFSM4I2XM33KYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOUCOUYQQ#event-2694663234, or mute the thread https://github.com/notifications/unsubscribe-auth/AJQ562A5EGHKRFPSECESEATQNREHTANCNFSM4I2XM33A .

Antagony1060 commented 4 years ago

No worries. I hadn't noticed that because there is a space to the right of the slash and with quotation marks on the left it wasn't obvious.

I did wonder whether the pipe symbol (|) might be a better divider, as it's less likely to be used in a clue's text and, to my eyes at least, looks somewhat cleaner. But to be honest I don't think it really matters much, given how rare multiline clues are likely to be.

viresh-ratnakar commented 4 years ago

I like "/" because it is also commonly used for showing line breaks when quoting poetry in prose (see, for example, https://writingcenter.ashford.edu/slashes).

On Tue, Oct 8, 2019 at 10:54 AM Antagony1060 notifications@github.com wrote:

No worries. I hadn't noticed that because there is a space to the right of the slash and with quotation marks on the left it wasn't obvious.

I did wonder whether the pipe symbol (|) might be a better divider, as it's less likely to be used in a clue's text and, to my eyes at least, looks somewhat cleaner. But to be honest I don't think it really matters much, given how rare multiline clues are likely to be.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/viresh-ratnakar/exolve/issues/10?email_source=notifications&email_token=AJQ562FW2AILOSMG3ZYTPYTQNTCL7A5CNFSM4I2XM33KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAVBMMQ#issuecomment-539629106, or mute the thread https://github.com/notifications/unsubscribe-auth/AJQ562G64F57C4F7NML53R3QNTCL7ANCNFSM4I2XM33A .

Antagony1060 commented 4 years ago

Honestly, it's fine! :\^)

Antagony1060 commented 4 years ago

Any chance you could make the tab navigation wrap between the last and first clues of each direction – i.e. the last across clue tabs to the first down clue, the last down clue tabs to the first across clue, and vice versa for shift tabbing?

PS. please say if you'd rather I opened a new issue rather than re-opening this one.

viresh-ratnakar commented 4 years ago

Done, in v0.49. ptal.

Antagony1060 commented 4 years ago

Great job as usual, thanks!