viresh-ratnakar / exolve

Online interactive crossword software in JavaScript
MIT License
73 stars 15 forks source link

'Clear this' should only clear crossing letters if the crossed entry is incomplete. #15

Closed Antagony1060 closed 4 years ago

Antagony1060 commented 4 years ago

I think most users would prefer them to be left in. But if you'd like to keep it as an option, maybe you could clear them if they're all that exists? In other words, two successive clicks would clear the whole set.

viresh-ratnakar commented 4 years ago

Yes, seems reasonable. Will try to get to this soon.

I wish there were concise labels possible that conveyed the semantics of all these buttons clearly. ("Clear this" has these two phases, "Reveal this" also shows hints/annos, "Reveal all" also shows explanatory notes and ninas, "Check this" behaves like "Reveal this" if there is no error, etc.).

Antagony1060 commented 4 years ago

Yeah, I guess it's one of the drawbacks of trying to cater for different needs in a logical manner.

I've checked how the Guardian's 'Clear this' button works and it never clears the crossers of completed entries. From my personal experience of using their site a lot, I can't recall ever wishing it did and I'm struggling to think of a scenario where someone would. There again, I don't really use the 'Clear this' button that often anyway, as I tend to only enter answers when I'm reasonably sure about them. Still, if it were me I think I'd just program the first phase and wait to see if anyone ever asks for the second.

viresh-ratnakar commented 4 years ago

With v0.34, "Clear this" will only clear non-crossing letters first. If there are none, then it will clear the crossing letters.

Antagony1060 commented 4 years ago

Hmm, that's not quite what I had in mind. I don't see any value in leaving crossers uncleared if they're not part of a completed entry. Take 15d in this grid for example. In my view 'Clear this' should result in S _ _ _ E | _ _ _ _ on the first click.

viresh-ratnakar commented 4 years ago

Ah, yes, thanks, makes sense.

Fixed now in v0.35, ptal.

Antagony1060 commented 4 years ago

Perfect, thanks!