viresh-ratnakar / exolve

Online interactive crossword software in JavaScript
MIT License
73 stars 15 forks source link

Pictures in clues, NW corner #17

Closed ballantynedewolf closed 4 years ago

ballantynedewolf commented 4 years ago

image I like how this looks, but if the clue were for a light in the NW corner, I wouldn't be able to fill it in.

viresh-ratnakar commented 4 years ago

Can you please share the relevant lines from the exolve-across section?

It looks to me like you have an <img> tag in the clue. I can add code to look for and scrub it out for the version of the clue shown as the "current highlighted clue." However, I do not fancy that idea greatly (what else should I code to look for, for example?).

A workaround can be to include the <img> tag just above (and hence outside the clue text), like this:

exolve-across: ... 15 whatever... <img .../> 17 First name [of the person pictured] (5)

ballantynedewolf commented 4 years ago

Yes, that works. Can put the img before or after the clue and refer to it's location or tooltip in words, only thing is that float is no longer helpful to make it look nice. Solved that by styling the img 100% width J

@@-? ( - the fashion and sober design will make you special

On Thu, 14 Nov 2019 at 09:31, Viresh Ratnakar notifications@github.com wrote:

Can you please share the relevant lines from the exolve-across section?

It looks to me like you have an tag in the clue. I can add code to look for and scrub it out for the version of the clue shown as the "current highlighted clue." However, I do not fancy that idea greatly (what else should I code to look for, for example?).

A workaround can be to include the tag just above (and hence outside the clue text), like this:

exolve-across: ... 15 whatever... <img .../> 17 First name [of the person pictured] (5)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/viresh-ratnakar/exolve/issues/17?email_source=notifications&email_token=AGBJIAO53W3B7HVQE4VDL7DQTR53NA5CNFSM4JNB2LM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOED74YRY#issuecomment-553634887, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGBJIAJCGWSO6X2EPGBQYCDQTR53NANCNFSM4JNB2LMQ .

viresh-ratnakar commented 4 years ago

Closing this issue, please reopen if needed.