visually mark clues that have been filled in - Githubissues

viresh-ratnakar / exolve

Online interactive crossword software in JavaScript

MIT License

73 stars 15 forks source link

visually mark clues that have been filled in #19

Closed martindemello closed 4 years ago

martindemello commented 4 years ago

e.g. have a little checkmark next to the clue number if the light has been fully filled in, or change the colour of the clue text

viresh-ratnakar commented 4 years ago

Nice idea!

Done, in v0.39:

When a light is filled in fully, change the colour of its clue-number. The colour is chosen to be a light shade of blue so that:
- unsolved clues show with darker numbers
- shade of blue not green as green may be construed as "correct" and we're not checking correctness
- using a checkmark instead of changing the colour has tedious issues (either shift the clue text to make room, or worry about clipping/eclipsing).

viresh-ratnakar commented 4 years ago

There was a minor bug in the changes made in v0.39, fixed now in v0.40.

Antagony1060 commented 4 years ago

I've just noticed in this completed puzzle that this isn't working with linked clues.

viresh-ratnakar commented 4 years ago

Can you please check after updating to the latest version (now v0.42). I fixed a few corner cases for this in v0.41 and am hopeful that this one was covered (if not, will debug and fix).

Antagony1060 commented 4 years ago

Updated and still the same I'm afraid.

viresh-ratnakar commented 4 years ago

OK, found and fixed this particular issue with v0.43.

Antagony1060 commented 4 years ago

Great stuff, thanks!

viresh-ratnakar commented 4 years ago

Closing this (seems to be working OK now, but reopen if needed)