‘Reveal all’ doesn't always work

[Antagony1060]

I noticed this on a larger (10 x 8) puzzle I'm working on, but I've experimented with smaller sizes and this 4 x 3 grid behaves similarly:

exolve-begin
  exolve-width: 4
  exolve-height: 3
  exolve-grid:
    C R E W
    A|N|L|E
    R A I D
exolve-end

As you will see, it doesn't fill the last column on the right for some reason. With the larger puzzle it only fills the top row, which is T H I S|L I N E and nothing else below it. The 'Reveal this' button seems to work fine on any clue.

I think it may be related, but I've also noticed with this grid that tab navigation doesn't work at all either.

[viresh-ratnakar]

Will debug soon, thanks! On the face of it, it seems that I've accidentally used width in place of height (or vice versa) somewhere in the code, creating a bug only exposed by non-square grids.

On Fri, Feb 21, 2020, 12:52 PM Antagony1060 notifications@github.com wrote:

I noticed this on a larger (10 x 8) puzzle I'm working on, but I've experimented with smaller sizes and this 4 x 3 grid behaves similarly:

exolve-begin exolve-width: 4 exolve-height: 3 exolve-grid: C R E W A|N|L|E R A I D exolve-end

As you will see, it doesn't fill the last column on the right for some reason. With the larger puzzle it only fills the top row, which is T H I S|L I N E and nothing else below it. The 'Reveal this' button seems to work fine on any clue.

I think it may be related, but I've also noticed with this grid that tab navigation doesn't work at all either.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/viresh-ratnakar/exolve/issues/23?email_source=notifications&email_token=AJQ562CX37CGOY75T2ISMO3REA5IVA5CNFSM4KZKGAQ2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IPM7GKQ, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJQ562DDXBGFGUIS4QVHJPLREA5IVANCNFSM4KZKGAQQ .

[Antagony1060]

Thanks! I'm sure you're right because taking the bottom two rows off the larger grid makes everything reveal as normal and taking a third row off breaks it again but with a missing column instead of rows.

[viresh-ratnakar]

yeah it's a single "gridHeight" instead of "gridWidth" in the revealAll() function. Will release the fix later tonight.

the tab navigation works once you provide the clues (my tab navigation code takes its ordering from the list of clues -- I suppose I can and will also make that work even when no clues are provided, just for completeness)

On Fri, Feb 21, 2020 at 2:30 PM Antagony1060 notifications@github.com wrote:

Thanks! I'm sure you're right because taking the bottom two rows off the larger grid makes everything reveal as normal and taking a third row off breaks it again but with a missing column instead of rows.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/viresh-ratnakar/exolve/issues/23?email_source=notifications&email_token=AJQ562FIA3A4JRUHZE2PR4TREBIYHA5CNFSM4KZKGAQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMUJ3WI#issuecomment-589864409, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJQ562GEGVMII2WRB3RKYEDREBIYHANCNFSM4KZKGAQQ .

[Antagony1060]

Of course, I should have realised it was the lack of clue lists. With all the other navigation methods still working I guess I just assumed shifting would too.

Please don't rush to publish a fix on my account. I'm not in any hurry, I just found the bug and wanted to let you know about it.

[viresh-ratnakar]

I've uploaded the fix in v0.50

[Antagony1060]

Tested and working fine now, thanks!