viresh-ratnakar / exolve

Online interactive crossword software in JavaScript
MIT License
73 stars 15 forks source link

"Instructions" grid does not display in Edge browser #28

Closed Raceous closed 4 years ago

Raceous commented 4 years ago

The latest 1Across grid, "Instructions", does not display in Microsoft Edge or Internet Explorer on Windows 10. Here is a screenshot from Edge. (Enlarging the Edge window does not help.) The appearance in IE is similar. image

viresh-ratnakar commented 4 years ago

Hmm, I have zero access right now to a Windows machine, unfortunately.

If you can bring up the JavaScript console and see if there are any error messages, that might help.

On Sun, May 24, 2020, 6:13 PM Raceous notifications@github.com wrote:

The latest 1Across grid, "Instructions", does not display in Microsoft Edge or Internet Explorer on Windows 10. Here is a screenshot from Edge. (Enlarging the Edge window does not help.) The appearance in IE is similar. [image: image] https://user-images.githubusercontent.com/54013910/82769560-f74a3d80-9de9-11ea-8b11-f52a0685dabd.png

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/viresh-ratnakar/exolve/issues/28, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJQ562BFQU4HBPKWBSK2AP3RTHAZXANCNFSM4NJEF5LA .

viresh-ratnakar commented 4 years ago

Another useful piece of info would be whether some older grid works (to identify if the issue is limited to the current puzzle or to some recent core software change)

On Sun, May 24, 2020, 6:24 PM Viresh Ratnakar viresh@gmail.com wrote:

Hmm, I have zero access right now to a Windows machine, unfortunately.

If you can bring up the JavaScript console and see if there are any error messages, that might help.

On Sun, May 24, 2020, 6:13 PM Raceous notifications@github.com wrote:

The latest 1Across grid, "Instructions", does not display in Microsoft Edge or Internet Explorer on Windows 10. Here is a screenshot from Edge. (Enlarging the Edge window does not help.) The appearance in IE is similar. [image: image] https://user-images.githubusercontent.com/54013910/82769560-f74a3d80-9de9-11ea-8b11-f52a0685dabd.png

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/viresh-ratnakar/exolve/issues/28, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJQ562BFQU4HBPKWBSK2AP3RTHAZXANCNFSM4NJEF5LA .

Raceous commented 4 years ago

The previous 3 grids have also stopped working. LP.html and NJC.html appear the same as above. WH.html (Wormholes) appears as a completely blank page. Screenshots of console output follow. (Let me know if you would prefer these as text)

image

image

image

image

viresh-ratnakar commented 4 years ago

Looks like the error thrown at exolve-m.js:610 is the/a core problem. This code was indeed added when I added non-English support recently.

try { languageScript = 'Devanagari' scriptRE = new RegExp('\p{Script=' + languageScript + '}', 'u') scriptLowerCaseRE = new RegExp('\p{Lowercase}', 'u') } catch { }

Can you please type these lines in the browser's JavaScript console, one at a time, and let me know what error messages pop up, when you get the chance. I'm expecting some syntax errors. And then I want to check if the syntax errors go away with some easy fixes.

On Sun, May 24, 2020 at 7:10 PM Raceous notifications@github.com wrote:

The previous 3 grids have also stopped working. LP.html and NJC.html appear the same as above. WH.html (Wormholes) appears as a completely blank page. Screenshots of console output follow. (Let me know if you would prefer these as text)

[image: image] https://user-images.githubusercontent.com/54013910/82771655-97f02b80-9df1-11ea-8de2-1aa4cfe47fbb.png

[image: image] https://user-images.githubusercontent.com/54013910/82771693-b2c2a000-9df1-11ea-8616-3a773a311cd0.png

[image: image] https://user-images.githubusercontent.com/54013910/82771723-ccfc7e00-9df1-11ea-84e7-bbc1a0484dc3.png

[image: image] https://user-images.githubusercontent.com/54013910/82771815-1351dd00-9df2-11ea-8d3f-770dad574442.png

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/viresh-ratnakar/exolve/issues/28#issuecomment-633342075, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJQ562HNY4SLHSAJDLLTZCLRTHHQBANCNFSM4NJEF5LA .

Raceous commented 4 years ago

Reopened In.html and copied the whole code fragment: image

viresh-ratnakar commented 4 years ago

OK, thanks! Sorry, but we'll have to drill down a bit more. Here are variants aht ablate various aspects of the above. Please try them separately.

1. try { languageScript = 'Devanagari' catch { }

2. scriptLowerCaseRE = new RegExp('\p{Lowercase}', 'u')

3. scriptRE = new RegExp('test1', 'u')

4. scriptRE = new RegExp('\test2', 'u')

5. try { scriptRE = new RegExp('test1', 'u') catch { }

6. try { scriptRE = new RegExp('\test1', 'u') catch { }

Or anything that useful variation can think of :-). Thanks!

Raceous commented 4 years ago

Here you go: image

viresh-ratnakar commented 4 years ago

Debugged through discussion, thanks!

Fixed with v0.73.

Raceous commented 4 years ago

Verified that the grid can now be viewed in Edge.