virgili0 / Virgilio

Your new Mentor for Data Science E-Learning.
https://virgili0.github.io/Virgilio/
Other
13.91k stars 2.49k forks source link

Broken link to Virgilio's official Matrix Algebra guide jupyter notebook #105

Closed tataganesh closed 4 years ago

tataganesh commented 4 years ago

The link Virgilio's official Matrix Algebra guide jupyter notebook is broken. ( This is present in linear-algebra-and-matrix-algebra).

clone95 commented 4 years ago

thanks, fixing it

neomatrix369 commented 4 years ago

One-off

$ pip install -U markdown-link-check

Recursively find broken links

<in the root directory of the folder, in the dev branch>
$ ls **/*.md | xargs -n 1 markdown-link-check -q

or

$ ls **/*.md | xargs -n 1 markdown-link-check -q &> broken-links.txt
$ cat broken-links.txt

Here's what I found on 02-Jun-2020: broken-links.txt

avivace commented 4 years ago

Thanks @neomatrix369, we should add that linting rule to the CI/CD setup so we can immediatly spot this kind of stuff

neomatrix369 commented 4 years ago

Thanks @neomatrix369, we should add that linting rule to the CI/CD setup so we can immediatly spot this kind of stuff

Love that idea, and wake @clone95 up to let him know that pigeons have arrived with news about Virgilio ;) :p

Adding to CI/CD is better than running it manually each time.

neomatrix369 commented 4 years ago

I found some more broken links, see broken-links.txt

Is the CI/CD task or GitHub action already setup to pick up broken links?

Also see https://github.com/virgili0/Virgilio/issues/111