search

virgo-agent-toolkit / rackspace-monitoring-agent

Rackspace Cloud Monitoring Agent
http://virgoagent.com/rackspace-monitoring-agent/
Apache License 2.0
118 stars 39 forks source link

Build lit as part of regular Windows build #980

Closed itzg closed 5 years ago

itzg commented 5 years ago

Fixes

https://jira.rax.io/browse/CMC-2273

What

Even with the luvi set to 2.9.3-sigar in package.lua the built agent exe was producing an error like https://github.com/luvit/lit/issues/252 .

What ended up fixing this (in local build testing at least) was doing two things:

  1. Build lit from source, such as what the Linux builder script does here: https://github.com/virgo-agent-toolkit/rackspace-monitoring-agent-buildbot-builder/blob/master/build.sh#L38-L44
  2. Instead of putting the lit-building logic way over in that repo, just incorporate it into this repo's make.bat since it was already doing "get lit" stuff
itzg commented 5 years ago

FYI it took some tweaks in final testing to get this working since the version of PowerShell was older than expected, reg wasn't usable, but found LUVI_ARCH is set in buildbot's definition anyway:

https://github.com/virgo-agent-toolkit/rackspace-monitoring-agent/compare/5a86eda66c9006041a61cdcce5dfaba69ecbfae2...3b9b3818091c0486c8e3fe433ac91ce864dc4fe9