search

viritin / flow-viritin

Viritin inspired project for Vaadin Flow
Other
41 stars 16 forks source link

New components #10

Closed melistik closed 5 years ago

melistik commented 5 years ago

i've added missing components and separated each component package to have better overview.

In general I would welcome to move each fluent component-module in a separate package. My suggestion would be to move existing html-components to org.vaadin.firitin.components.hmtl When you like my approache I could create an extra pull-request (but this would like to breaking changes for other who already use viritin-flow)

mmerruko commented 5 years ago

A late thank you for the contribution :)

melistik commented 5 years ago

You are welcome ;)

Regarding my other pull request: Is an edge version interesting? We use it already in our own project because of the missing components in the LTS version...

mmerruko commented 5 years ago

I have quickly discussed this with @mstahv and our view is that changes that apply in the LTS could be in an LTS/master branch, and we can have separate branch(es) for the latest releases instead of two separate projects.

Let's continue the discussion on the other PR comment thread, thank you once more for contributing :)