search

viritin / flow-viritin

Viritin inspired project for Vaadin Flow
Other
41 stars 16 forks source link

Continuation of new fluent interfaces and components #3

Closed stefan-freude closed 6 years ago

mstahv commented 6 years ago

Lot of good stuff here, I'll look into this!

mstahv commented 6 years ago

Could you rebase the changes on the master branch?

@mmerruko we also need to do the tabs-vs-spaces decision ;-) I'd go with spaces (IntelliJ defaults).

stefan-freude commented 6 years ago

I rebased the project and used spaces (as default). I don't know, why github has conflicts in VTextField.java, I added FluentHasStyle, withId an rearranged imports.

mstahv commented 6 years ago

Thanks Stefan, your first code contribution is in, keep them coming!

mstahv commented 6 years ago

@mmerruko & @stefan-freude project now has formatter plugin configured. You can issue it by executing mvn formatter:format , which should do pretty much the same as default eclipse settings.