search

viritin / flow-viritin

Viritin inspired project for Vaadin Flow
Other
39 stars 15 forks source link

Recreate DownloadButton from V8 viritin #35

Closed knoobie closed 2 years ago

knoobie commented 2 years ago

Currently viritin only has a DynamicFileDownloader based on the Anchor component. In the past the DownloadButton extended the Button component resulting in the same visual appearance as other actions and setDisableOnClick which is tremendous important to reduce the duplicate generation of downloads, reducing the stress on server / loads and allowing the user to get instant visible feedback that a task was triggered.

This feels like an important missing feature in my opinion.

mstahv commented 2 years ago

Added some API to make the component appear as Button and a generic method to make the download disabled immediately after it has been clicked. Check out the usage from demo code and let me know if you want something else!

knoobie commented 2 years ago

Thanks Matti! Gonna try it next week and give you feedback :)