virocon-organization / virocon

A Python package to compute environmental contours.
MIT License
26 stars 11 forks source link

Parameters not fitting very well #170

Open matheusposilva opened 1 year ago

matheusposilva commented 1 year ago

Hello everyone

I'm trying to obtain the Environmental contour of my data, but the parameters {"sigma": exp3} is not fitting very well Any one could help me with this issue

image

ahaselsteiner commented 1 year ago

Hi @matheusposilva

Are you working with wind speed - wave height data or with wave period wave height data?

And is this one of our predefined models (https://github.com/virocon-organization/virocon/blob/master/virocon/predefined.py). If yes, which one?

You might wanna try a different model predefined model or you could define a different dependence function for sigma.

Feel free to post a scatter plot of your raw data here too. That would give me an idea if you are working with a typical dataset or if the dataset has features that are uncommon.

matheusposilva commented 1 year ago

Hi @ahaselsteiner I am using a predefined model. The data I am using is from HsxTp in the southeastern region of Brazil, taken from ERA5. image

The data and the python arquive is attached arquivo.py.txt ec-benchmark_dataset_A.txt

ahaselsteiner commented 1 year ago

@matheusposilva in your code you define the model yourself, but it looks like you are using the DNVGL_Hs_Tz model (https://github.com/virocon-organization/virocon/blob/master/virocon/predefined.py#L23C1-L23C23).

You could just import this model instead of defining it yourself, similar to this example: https://github.com/virocon-organization/virocon/blob/master/examples/hstz_contour_simple.py

If you are not satisfied with the fit you could try if the OMAE2020_Hs_Tz fits better (https://github.com/virocon-organization/virocon/blob/master/virocon/predefined.py#L145).