virocon-organization / viroconweb

A software to compute environmental contours. Django web-application package.
MIT License
2 stars 1 forks source link

Weird error message when trying to calculate a contour with a wrong probabilistic model #144

Closed ahaselsteiner closed 6 years ago

ahaselsteiner commented 6 years ago

I'm submitting a ...

Expected behavior

How should it work (with the bug fixed or the feature implemented)? The error messages should be clearer. If a probabilistic model is such that no environmental contour can be calculated, the probabilistic model should not be allowed to be created at all.

Screenshot

Actual behavior

How does it currently work (with the bug causing problems or without the feature)?

Screenshot Probabilistic model: image

IFORM: image

image

HDC: image

image

Steps to reproduce the problem (how to see the actual behavior)

  1. Create the probabilistic model shown in the screenshot
  2. Calculate an IFORM or HDC contour
  3. See the strange error messages
ahaselsteiner commented 6 years ago

For some reason I cannot reproduce this error.

Model resulting when I fit LN LN(power, power) to the Vanem2012 data set: image

(The model is different from the one shown in the issue, probably because of changes by Tobias and Jannik to the fitting and handling of shape/loc/scale and mu.

When I try to enter the probabilistic model directly I get the error message that no negativ values are allowed (for the ^-0.16).

Resulting contour: image

ahaselsteiner commented 6 years ago

Since I cannot reproduce this error and a wrong error message would not be a high-priority issue I am closing this issue.