virocon-organization / viroconweb

A software to compute environmental contours. Django web-application package.
MIT License
2 stars 1 forks source link

Properly handle the error when a contour with a wrong model is being computed #149

Closed ahaselsteiner closed 6 years ago

ahaselsteiner commented 6 years ago

I'm submitting a ...

Expected behavior

How should it work (with the bug fixed or the feature implemented)? The user should be presented with a proper error message.

Screenshot

Actual behavior

How does it currently work (with the bug causing problems or without the feature)? Locally (with DEBUG=True) the error is shown in the view, with DEBUG=false probably the 500-error page would be shown.

Screenshot Model: image

Contour settings: image

Result: image

Steps to reproduce the problem (how to see the actual behavior)

  1. Create the problematic model (see screenshot)
  2. Try to compute an IFORM contour with the given settings (see screenshot)
  3. Get the error
ahaselsteiner commented 6 years ago

Since the error is currently not catched on heroku / in production this error leads to the following page: image

ahaselsteiner commented 6 years ago

Input: image

Error: image

image

ahaselsteiner commented 6 years ago

Handling the case with infinity now:

image

ahaselsteiner commented 6 years ago

And for the the other case: image

We now get this error message: image

ahaselsteiner commented 6 years ago

Done.