virocon-organization / viroconweb

A software to compute environmental contours. Django web-application package.
MIT License
2 stars 1 forks source link

scale and mu conversion is incorrect #151

Closed topape closed 6 years ago

topape commented 6 years ago

I'm submitting a ...

Expected behavior

How should it work (with the bug fixed or the feature implemented)? The mu value should be used in the fit report not the scale value declared as mu value.

Screenshot The correct mu value inserted.

bildschirmfoto 2018-04-27 um 10 04 51

Actual behavior

How does it currently work (with the bug causing problems or without the feature)? In the latex description of the probabilistic model the mu parameter is incorrect. Currently the scale parameter will be plotted and declared as mu.

Screenshot The latex fit report with the scale value declared as mu.

bildschirmfoto 2018-04-27 um 10 04 51

observering outputs into the Terminal to check the mu and scale values. The 'scale adjusted to mu' value is the correct mu value. This value must be used in the latex report.

bildschirmfoto 2018-04-27 um 10 06 35

Correct mu value in the image title

bildschirmfoto 2018-04-27 um 10 35 40

Steps to reproduce the problem (how to see the actual behavior)

  1. upload measure file (vanem)
  2. fit the file with 1. and 2. variabel as Log-Normal distribution
  3. investigate the latex fit result and the image titles (scale parameter) or check the terminal
ahaselsteiner commented 6 years ago

Great bug report, thanks for spotting this!

ahaselsteiner commented 6 years ago

I could not reproduce this problem. I think this issue does is not in the master branch, but is a problem you face in the implentation of issue#41 together with the changes in compute.

This is a screenshot when I tried to reproduce the bug: image

Please close the issue if it is true that it does not a problem of the master branch.

topape commented 6 years ago

Issue was a problem in the branch: issue#41