virocon-organization / viroconweb

A software to compute environmental contours. Django web-application package.
MIT License
2 stars 1 forks source link

Inconsistency in plot of fits #158

Closed ahaselsteiner closed 6 years ago

ahaselsteiner commented 6 years ago

I'm submitting a ...

Expected behavior

How should it work (with the bug fixed or the feature implemented)? The mu value should be plotted correctly.

Screenshot

Actual behavior

How does it currently work (with the bug causing problems or without the feature)? Either in the plot of a basic fit or in a fit of fits the mu has a wrong value. In the screenshot shown below the mu value for the interval 12<Hs<14 is 2.5 in the basic fit plot and about 12.5 in the fit of fit plot.

Only one value can be correct.

Probably the fit of fit plot is incorrect and the problem is probably due to a problem with the mu conversion.

Screenshot image

Steps to reproduce the problem (how to see the actual behavior)

  1. Fit the correct Vanem model to the Vanem data set
  2. Visually inspect the fit
  3. See the inconsistency
ahaselsteiner commented 6 years ago

@topape Since you are working on plotting: Can you take a look at this issue?

topape commented 6 years ago

I fixed it

bildschirmfoto 2018-05-07 um 16 04 45