search

viromedia / virocore

ViroCore cross-platform AR/VR renderer
MIT License
360 stars 108 forks source link

amazonaws dependency problem #212

Open henryszex42s opened 5 years ago

henryszex42s commented 5 years ago

I am facing a problem of missing the class of Lcom/amazonaws/auth/CognitoCachingCredentialsProvider;

However, I find that the build.grade in sample project [ARBlackPanther] include those dependencies: implementation 'com.amazonaws:aws-android-sdk-core:2.2.+' implementation 'com.amazonaws:aws-android-sdk-ddb:2.2.+' implementation 'com.amazonaws:aws-android-sdk-ddb-mapper:2.2.+' implementation 'com.amazonaws:aws-android-sdk-cognito:2.2.+' implementation 'com.amazonaws:aws-android-sdk-cognitoidentityprovider:2.2.+'

If I add those of the dependecies to my build.grade, everything will be fine.

But I still want to ask why we need to include those sdk? and using for what purpose? It seems that doesn't related to AR experience.

VikAdvani commented 5 years ago

Hi @henryszex42s, The reason we require the aws sdk's is for key checking. We check the API key to make sure it's valid. If we are unable to properly connect or the device is offline then the Viro renderer will continue to render. If the key is proven to be valid, then rendering continues. If the key is invalid, rendering stops. This occurs only if the key is proven to be invalid.

Let me know if you need any more clarification. Thanks.

henryszex42s commented 5 years ago

Hi @VikAdvani , Thanks for your reply. Now, I know that those SDK are using for key checking. However, there are other ways to complete the key checking? Since for some reasons, I have concern on using aws's sdk.