GLTF nodes hierarchy - Githubissues

dbathily commented 5 years ago

[x] Review the documentation: https://virocore.viromedia.com/
[x] Search for existing issues: https://github.com/viromedia/virocore/issues
[x] Use the latest ViroCore release: https://virocore.viromedia.com/docs/releases
[x] Turn off Instant Run in Android Studio

Environment

Please provide the following information about your environment:

OS: Mac
Version: ViroCore version 1.13.0
Device(s): What device(s) are you are seeing the issue on (i.e. Samsung Note 8, Pixel 2 XL, etc) One+ 6

Description

Does ViroCore preserve GLTF nodes hierarchy? After importing our model, we don't find the same hierarchy and the nodes doesn't have a name. We need to access a node by it's name

dbathily commented 5 years ago

@dthian as you asked on slack here is more informations.

For the following GLTF model screenv3.glb.zip, here is the hierarchy we have on ARKit:

- <Easytopia.ETExperienceSceneChildNode: 0x12aeb75f0 rot(0.000000 -1.000000 0.000000 1.335752) | 1 child> 
- animations : []
- light : 
    - <SCNNode: 0x12af830f0 'RootNode' | 1 child> RootNode
    - animations : []
    - light : 
        - <SCNNode: 0x12af7bae0 'Group001' pos(0.000000 0.000000 -0.024188) rot(-1.000000 0.000000 0.000000 1.570796) scale(100.000000 100.000000 100.000000) | 3 children> Group001
        - animations : []
        - light : 
            - <SCNNode: 0x12af7bd20 'Rig 2 tv' pos(-0.000042 0.009002 0.012474) rot(0.000000 -0.000000 1.000000 3.141593) scale(1.000000 1.410180 1.000000) | no child> Rig 2 tv
            - animations : ["translation", "12C52C93-CC2B-492D-A395-188B8F866ADE", "idle"]
            - light : 
            - <SCNNode: 0x12af44650 'Rig 1 tv' pos(-0.000066 0.008990 0.015255) rot(0.577350 0.577350 -0.577350 2.094395) | 4 children> Rig 1 tv
            - animations : ["translation", "BCDFCAC2-7266-41C6-AAFC-885A9DD234A3", "idle"]
            - light : 
                - <SCNNode: 0x12af44950 'cadretv glow 2' pos(-0.000059 0.000024 -0.000365) rot(1.000000 0.000000 0.000000 3.141592) scale(0.060442 0.060298 0.063384) | 1 child> cadretv glow 2
                - animations : []
                - light : 
                    - <SCNNode: 0x12af488b0 'cadretv glow 2' | 1 child> cadretv glow 2
                    - animations : []
                    - light : 
                        - <SCNNode: 0x12af48b30 | geometry=<SCNGeometry: 0x10f8cc490> | no child> 
                        - animations : []
                        - light : 
                - <SCNNode: 0x12af3ba10 'quadrillage glow' pos(-0.000059 0.000024 -0.000572) rot(1.000000 0.000000 -0.000000 3.141592) scale(0.074422 0.074422 0.074422) | 1 child> quadrillage glow
                - animations : []
                - light : 
                    - <SCNNode: 0x12af3cca0 'quadrillage glow' | 1 child> quadrillage glow
                    - animations : []
                    - light : 
                        - <SCNNode: 0x12af50710 | geometry=<SCNGeometry: 0x12ae76c30> | no child> 
                        - animations : []
                        - light : 
                - <SCNNode: 0x12af80fb0 'quadrillage glow 2' pos(-0.000059 0.000024 -0.000599) rot(1.000000 0.000000 -0.000000 3.141592) scale(0.074422 0.074422 0.074422) | 1 child> quadrillage glow 2
                - animations : []
                - light : 
                    - <SCNNode: 0x12af62f30 'quadrillage glow 2' | 1 child> quadrillage glow 2
                    - animations : []
                    - light : 
                        - <SCNNode: 0x12af5ea90 | geometry=<SCNGeometry: 0x12aec7c20> | no child> 
                        - animations : []
                        - light : 
                - <SCNNode: 0x12af68050 'Cadre tv glow' pos(-0.000178 0.000267 -0.000142) rot(0.999919 0.000000 0.000000 0.012333) scale(0.068847 0.071261 0.063384) | 1 child> Cadre tv glow
                - animations : []
                - light : 
                    - <SCNNode: 0x12af958a0 'Cadre tv glow' | 1 child> Cadre tv glow
                    - animations : []
                    - light : 
                        - <SCNNode: 0x12af93790 | geometry=<SCNGeometry: 0x12af38c20> | no child> 
                        - animations : []
                        - light : 
            - <SCNNode: 0x12af7e780 'ecran tv' pos(-0.000042 0.008935 0.015322) rot(0.577351 -0.577350 -0.577350 4.188790) scale(0.064220 0.064284 0.063384) | 1 child> ecran tv
            - animations : ["translation", "3F04F89F-BF34-43C6-B7DB-085E2196650C", "idle"]
            - light : 
                - <SCNNode: 0x12af45200 'ecran tv' | 1 child> ecran tv
                - animations : []
                - light : 
                    - <SCNNode: 0x12af74120 | geometry=<SCNGeometry: 0x12ae55840> | no child> 
                    - animations : []
                    - light :

Which is the same on babylon.js

dthian commented 5 years ago

Thanks @dbathily for providing the above information. I've identified the bug in the renderer and have patched a fix. I'll update this issue once the fix has been deployed in the upcoming release (scheduled to be this coming week or the week after).

dbathily commented 5 years ago

@dthian 1.14.0 fix this issue. Thank you 👍

viromedia / virocore

GLTF nodes hierarchy #267

Environment

Description