iOS - Update Google dependencies?

viromedia / virocore

ViroCore cross-platform AR/VR renderer

MIT License

370 stars 108 forks source link

iOS - Update Google dependencies? #320

Open cristianoccazinsp opened 5 years ago

cristianoccazinsp commented 5 years ago

[X] Review the documentation: https://virocore.viromedia.com/
[X] Search for existing issues: https://github.com/viromedia/virocore/issues
[X] Use the latest ViroCore release: https://virocore.viromedia.com/docs/releases
[X] Turn off Instant Run in Android Studio

Environment

Please provide the following information about your environment:

OS: Mac
Version: ViroCore version - The one used by react-viro 2.17
Device(s): iPhone

Description

Hello, opening this issue as a follow up from https://github.com/viromedia/viro/issues/718

Apple is rejecting apps that use UIWebView, and right now it seems like react-viro, which uses viro core, is referencing UIWebView somewhere. Someone hinted that the references come from google's SDK, can those be updated? Can we get some help to remove any UIWebView reference?

Thanks.

Reproducible Demo

mstrokin commented 4 years ago

@dthian If it's not possible to update the google SDK, is it possible to 'deprecate' the ViroViewGVR and other files related to GVR, thus dropping the support for stereo VR headsets, but still keeping the AR intact?

Hless commented 4 years ago

From what I understand we should replace the GVRSDK library with the new open source Cardboard library, which no longer contains references to UIWebView. They also appear to have some new features/fixes on the roadmap for that new library

nickarora commented 4 years ago

Bumping this; this is critical to any app that plans to use this in production. Submissions to the AppStore will soon all be rejected because of the reference to UIWebView. @dthian is there a plan to update the library?

dthian commented 4 years ago

@nickarora ViroMedia has no active roadmap or plans at the moment. However, as ViroCore is now open sourced (the build instructions are laid out within the ReadMe), please feel free to make the necessary changes if need be.

If i've time, I might take a peak into this issue this weekend.

TwR-Slice commented 4 years ago

any news on this issue? would it be possible to remove GVR without loosing AR supprt?

brascene commented 4 years ago

@nickarora exactly, we're currently in phase of submiting the app, and the timing couldn't be worse, and also our hands are tied to make any changes.. any ideas how could we replace GVRSDK?

Jackyaung commented 4 years ago

I am facing the same problem, any solution ？

ktemby commented 4 years ago

I was able to get through the UIWebView issue in my RN 0.62.2 project last night - details here https://github.com/viromedia/viro/issues/852#issuecomment-641810778