search

viromedia / virocore

ViroCore cross-platform AR/VR renderer
MIT License
370 stars 108 forks source link

Remove ic_launcher from Android SDK #326

Open robderijk opened 4 years ago

robderijk commented 4 years ago

Environment

Please provide the following information about your environment:

  1. OS: Mac
  2. Version: 1.17.0
  3. Device(s): All

Description

The default ic_launcher.png icon is included in the ViroCore Android SDK which causes issues when building an .aab: Modules 'base' and 'feature_augmented_reality' contain entry 'res/mipmap-mdpi-v4/ic_launcher.png' with different content.. It is possible to get this removed from the SDK, I don't think it's of any use for an SDK.

Reproducible Demo

Add the ViroCore Android SDK as a dependency in a dynamic feature module and build the app bundle using ./gradlew bundleRelease.