search

virresh / StockD

EOD Stock data downloader.
https://virresh.github.io/projects/stockd
GNU General Public License v2.0
11 stars 4 forks source link

Add tests #13

Open virresh opened 4 years ago

virresh commented 4 years ago

Currently there are no tests whatsoever.

It'd be great if someone can help adding unit, integration and end-to-end tests. Any contribution in this regard will be appreciated.

EEM86 commented 4 years ago

@virresh helo, I can work on it. I'm going to work at java_client. What classes do you prefer to cover with tests first? Assign me to this task if your pleasure).

virresh commented 4 years ago

Hi @EEM86,

Thanks a lot for volunteering!

The java_client has been deprecated and is present for legacy purposes (noted in README here).

However, I'd like to recommend you the Python version. If you're even a bit comfortable with Python, you can start looking at https://github.com/virresh/StockD/blob/master/python_client/app/routes.py The core logic lies in that single python file itself.

The application is mainly based on a web-development framework flask, so all the UI-handling portion is done through html-css in static folder.

Since there isn't any existing test framework in use, feel free to use any framework if you feel comfortable in that.

Also, let me know if you're taking up the task of python testing, I'll assign you then :D

EEM86 commented 4 years ago

@virresh Oh, I'm terribly sorry. I read the README file but missed the info that java_client is deprecated. Unfortunately, I'm not familiar with Python, but I have it on my to-do list. So, maybe next time, when I'll be ready for Python tasks...

virresh commented 4 years ago

sure, no worries