search

virresh / StockD

EOD Stock data downloader.
https://virresh.github.io/projects/stockd
GNU General Public License v2.0
11 stars 4 forks source link

sunday data is not removed . #14

Closed jain203 closed 3 years ago

jain203 commented 3 years ago

Sunday data is not filtered . so we get duplicate data on every sunday. plz remove this bug.
image attached. image

virresh commented 3 years ago

Hi @jain203

Thanks for reporting, I don't use Amibroker so I cannot check for this bug. Can you give some additional details?

Do you get any .txt file for Sunday in the chosen downloaded location? Or does this happen only after importing the files in the software?

jain203 commented 3 years ago

text file for sunday oct- 18 ALL_2020OCT18.txt

virresh commented 3 years ago

Interesting Thanks for the sample text file @jain203

I have identified the issue

NSE's servers actually save data for previous friday on Sunday's data, which confuses the downloader when it's looking for data

Concretely, you can actually download data by feeding in Sunday on NSE website As a proof, try visiting (18th Oct 2020, Sunday) https://archives.nseindia.com/products/content/sec_bhavdata_full_18102020.csv You will get a csv file but with data of 16th Oct

But if you go to (17th Oct 2020, Saturday) https://archives.nseindia.com/products/content/sec_bhavdata_full_17102020.csv there will be no file downloaded, which is as expected

This only happens on the delivery data server, not on indices or futures (or other equity servers) and is very annoying. For now you have a couple of options:

Since this issue is not in downloader, but in the NSE Servers, It will take a while for me to see what I can do from my side to solve this issue.

Feel free to reply to this thread if the above two suggestions don't help

jain203 commented 3 years ago

thanks virresh, Sunday data is removed by Check the skip weekends option but we still get data for non weekends holiday .

virresh commented 3 years ago

Thanks for reporting. I think I have a permanent fix that I can apply on the software side to ensure that any files whose date doesn't match the expected date will be rejected.

I'll release the fixes as soon as I get some time to work on this. Will update this thread once I release the newer version.

virresh commented 3 years ago

@jain203 I have fixed this issue with v4.6 Link to download: https://github.com/virresh/StockD/releases/latest

Please test and feel free to re-open this issue / comment here in case it doesn't fix the issue for you.