search

virresh / matvt

Virtual Mouse for Android TV that can be controlled via remote itself.
GNU General Public License v3.0
211 stars 35 forks source link

Fix issues with pointer visibility duration and click delays #10

Closed virresh closed 2 years ago

virresh commented 3 years ago

Point 2 of https://github.com/virresh/matvt/issues/8#issuecomment-812868681 and https://gitter.im/virresh/community?at=60729023ae90f36840733a3d sums up the issue.

Need to debug and fix timers on posting of runnables.

4388450 commented 3 years ago

I might suggest that it will be a great idea if you will add a "long press" enable \ disable option in the app and should only be used when needed. Thanks for your work!

virresh commented 3 years ago

@4388450 thanks for the suggestion In case the project continues, will keep this in mind.

4388450 commented 3 years ago

Thanks. Because in the last few hours I had a lot of issues on certain apps because the long click option. So I will really appreciate if you can add a option to disable it

virresh commented 2 years ago

Pointer visibility Long press enable disable fixed by https://github.com/virresh/matvt/commit/ae5ca994be0c1ff1607beb97a4a242811590b293 in the TV version

Closing this issue.

KFMDMSolutions commented 2 years ago

the pointer is visible but it doesn't perform the click until you release the button

virresh commented 2 years ago

@KFMDMSolutions , do you think it'd be more intuitive if the click is performed as soon as the button is pressed instead of button release?

Any ideas on how to distinguish between a short press and a long press in this case?

KFMDMSolutions commented 2 years ago

@KFMDMSolutions , do you think it'd be more intuitive if the click is performed as soon as the button is pressed instead of button release?

Any ideas on how to distinguish between a short press and a long press in this case?

lets say i wanna record a 5 min voice message i have hold the button for 5 min and then speak for 5 min that makes it 10 min to record a 5min message.

it definably needs some delay to differentiate between a short press and a long press but that doesn't mean we need to wait for the click to complete

KFMDMSolutions commented 2 years ago

you can start the click after a 2 sec or more delay and stop it onkeyup

virresh commented 2 years ago

makes sense, although the clicks sent by the gesture API, don't have that kind of leverage. It needs a gesture made completely before sending and we can't cancel a gesture after it's sent because it's executed immediately. This makes implementing things like dragging and holding buttons for voice recording impossible.

Android will need to provide something else altogether in order for us to deal with this issue. This functionality exists in Android for sure (they use it with the inbuilt remotes and touchscreens), but haven't exposed the API for use by third-party apps like mine.

What you're describing will become possible with https://github.com/virresh/matvt/issues/11 Though probably not implementable at the moment.