virt-lightning / virt-lightning

Starts your VM on libvirt in a couple of seconds!
196 stars 43 forks source link

Set the Source project URL in setup.py #264

Closed ekohl closed 1 year ago

ekohl commented 1 year ago

I had a hard time to find the source. At first I read the website and then went to PyPI, but eventually I just searched using a search engine. This uses project_urls1 in setup.py to add URLs on PyPI, which makes it easier to find the source.

goneri commented 1 year ago

Great, thank you for the feedback.

Can you just either run the Black formatter or do the following change:

diff --git a/setup.py b/setup.py
index d67b92b..920cf77 100644
--- a/setup.py
+++ b/setup.py
@@ -72,6 +72,6 @@ setuptools.setup(
     },
     setup_requires=["setuptools_scm"],
     project_urls={
-        'Source': 'https://github.com/virt-lightning/virt-lightning',
-    }
+        "Source": "https://github.com/virt-lightning/virt-lightning",
+    },
 )
ekohl commented 1 year ago

Thanks for wrapping that up. I was too busy the past few days. Investigating virt-lightning falls in the category of investigating new tools, so low priority. But seeing a responsive maintainer is a good sign in that investigation :)