virtalabs / tapirx

Free and open-source medical device discovery and identification
GNU General Public License v3.0
28 stars 8 forks source link

DICOM Modality Mapping #17

Open awdeorio opened 4 years ago

awdeorio commented 4 years ago

Is your feature request related to a problem? Please describe. DICOM messages sometimes include a modality in the field used for identity by TapirX. For example, the XA1020422 is a X-Ray Angiography device.

Describe the solution you'd like TapirX could check if the identity field starts with one of the modality strings and add a field to the output. Field name could be category.

Describe alternatives you've considered

EDIT: now that I think more about it, these alternatives might be better.

Additional context Here are some examples from the wild (exact numbers are modified).

ransford commented 4 years ago

Do they always match [A-Z]{2,8}[0-9]+? What do the digits mean?

It wouldn't be too taxing to add a map lookup to run after each successful message parse.

awdeorio commented 4 years ago

I don't know if DICOM identifiers are always in the same format. I only have one example to work with.

Of course, the map lookup is easy. The design decision is: is it worth adding a field the Asset object to represent category? Then, plumbing that through to the CSV output, REST API output, etc.