netkvm: some piece of code in RSSCalcHash_Unsafe seems like it will never execute.

virtio-win / kvm-guest-drivers-windows

Windows paravirtualized drivers for QEMU\KVM

https://www.linux-kvm.org/page/WindowsGuestDrivers

BSD 3-Clause "New" or "Revised" License

1.92k stars 377 forks source link

netkvm: some piece of code in RSSCalcHash_Unsafe seems like it will never execute. #1006

Closed zjmletang closed 6 months ago

zjmletang commented 7 months ago

Describe the bug In RSSCalcHash_Unsafe function.The condition "if(hashTypes & NDIS_HASH_IPV6)" seems like it will never be executed. Because the condition "if(hashTypes & (NDIS_HASH_IPV6 | NDIS_HASH_IPV6_EX))" includes "if(hashTypes & NDIS_HASH_IPV6)".

Expected behavior Perhaps the code under the condition "if(hashTypes & NDIS_HASH_IPV6)" can be removed.

ybendito commented 7 months ago

Indeed. Thanks, we'll remote it.

zjmletang commented 7 months ago

ok, you're welcome.