search

virtio-win / kvm-guest-drivers-windows

Windows paravirtualized drivers for QEMU\KVM
https://www.linux-kvm.org/page/WindowsGuestDrivers
BSD 3-Clause "New" or "Revised" License
1.91k stars 377 forks source link

NetKVM: Enforce driver isolation in INF files #1061

Closed kostyanf14 closed 3 months ago

kostyanf14 commented 3 months ago

Resolve: https://issues.redhat.com/browse/RHEL-26207

YanVugenfirer commented 3 months ago

Let's start with this and fix SR-IOv failover later.

ybendito commented 3 months ago

@kostyanf14 I'd suggest to keep Win10 build to use %12 and use %13 in Win11 build. See also https://github.com/virtio-win/kvm-guest-drivers-windows/pull/1070 This will make the driver to work also on Server 2016. Additional note: existing HCK for NetKVM passes without INF isolation.

kostyanf14 commented 3 months ago

@ybendito

From MSDN about DIRID13:

Driver package's [Driver Store](https://learn.microsoft.com/en-us/windows-hardware/drivers/install/driver-store) directory.

For Windows 8.1 and later versions of Windows, specifies the path to the Driver Store directory where the driver package was imported.

I ran Windows Server 2016 HLK tests "DF - InfVerif INF Verification" and "Static Tools Logo Test" and both passed. I checked where netkvm.sys located and it is present in the Driver Store directory.

ybendito commented 3 months ago

@kostyanf14 If checkinf of Server 2025 WDK requires 16299 in the INF, the INF will not be installable on 2016

kostyanf14 commented 3 months ago

@ybendito I use INF from Win10 folder (DIRI13, target 10.0) for Server 2016. Only INF in Win11 folder will have DIRI13 + target 10.0.16299

ybendito commented 3 months ago

@ybendito I use INF from Win10 folder (DIRI13, target 10.0) for Server 2016. Only INF in Win11 folder will have DIRI13 + target 10.0.16299

This is not in the commit, is it?

YanVugenfirer commented 3 months ago

@ybendito I use INF from Win10 folder (DIRI13, target 10.0) for Server 2016. Only INF in Win11 folder will have DIRI13 + target 10.0.16299

This is not in the commit, is it?

It is here: https://github.com/virtio-win/kvm-guest-drivers-windows/pull/1063