search

virtio-win / kvm-guest-drivers-windows

Windows paravirtualized drivers for QEMU\KVM
https://www.linux-kvm.org/page/WindowsGuestDrivers
BSD 3-Clause "New" or "Revised" License
1.91k stars 377 forks source link

Viosock: Remove Coinstaller Stuff from the INF File #1064

Open MartinDrab opened 3 months ago

MartinDrab commented 3 months ago

The driver is installed in the Driver Store (DIRID 13) instead of the System Drivers directory (DIRID 12).

xuehuihui commented 3 months ago

Is the protocol not registered?

MartinDrab commented 3 months ago

It is not. I think the INFs were not responsible for registering it even before this PR (I did not notice such registrations). I can of course test this (old INFs) on a fresh machine.

xuehuihui commented 3 months ago

[VirtioSocket_Device_CoInstaller_AddReg] HKR,,CoInstallers32,0x00010000,"viosocklib.dll,ViosockCoInstaller" ==> The old INFs will register the protocol through the ViosockCoInstaller interface.

MartinDrab commented 3 months ago

[VirtioSocket_Device_CoInstaller_AddReg] HKR,,CoInstallers32,0x00010000,"viosocklib.dll,ViosockCoInstaller" ==> The old INFs will register the protocol through the ViosockCoInstaller interface.

Ah, OK, I missed that. I will improve the PR.

kostyanf14 commented 4 weeks ago

@MartinDrab

The build failed

C:\EWDK11\Program Files\Microsoft Visual Studio\2019\BuildTools\MSBuild\Microsoft\VC\v160\Microsoft.CppBuild.targets(436,5): error MSB8013: This project doesn't contain the Configuration and Platform combination of Debug|Win32. [C:\workspace\VirtIO-EWDK-11-21H2-SDV\viosock\installer\viosock-installer.vcxproj]
YanVugenfirer commented 3 weeks ago

@MartinDrab https://learn.microsoft.com/en-us/windows-hardware/drivers/install/using-an-extension-inf-file did you try to check "Extension INFs"?

MartinDrab commented 3 weeks ago

@MartinDrab https://learn.microsoft.com/en-us/windows-hardware/drivers/install/using-an-extension-inf-file did you try to check "Extension INFs"?

I came across them several days ago when working on another (unrelated) issue. I did not have time to look at them in more detail and possibly use them, however, I hope to get to it shortly.

kostyanf14 commented 1 week ago

@MartinDrab We merge https://github.com/virtio-win/kvm-guest-drivers-windows/pull/1087 to switch to the new EWDK. For now, we just disable viosock build for Win11.

MartinDrab commented 1 week ago

@MartinDrab We merge #1087 to switch to the new EWDK. For now, we just disable viosock build for Win11.

OK. I hope to work on this PR shortly and finish it. I apologize for this inconvenience.

kostyanf14 commented 1 week ago

@MartinDrab We merge #1087 to switch to the new EWDK. For now, we just disable viosock build for Win11.

OK. I hope to work on this PR shortly and finish it. I apologize for this inconvenience.

Not a problem. Disabling the build is not a complicated task. This is more problem for companies that release viosock.