netkvm: fix memory leak in TX overfragmenting flow

virtio-win / kvm-guest-drivers-windows

Windows paravirtualized drivers for QEMU\KVM

https://www.linux-kvm.org/page/WindowsGuestDrivers

BSD 3-Clause "New" or "Revised" License

1.91k stars 377 forks source link

netkvm: fix memory leak in TX overfragmenting flow #1084

Closed ybendito closed 2 months ago

ybendito commented 2 months ago

https://issues.redhat.com/browse/RHEL-24992 Memory leak of CNB::m_ExtraNBStorage happens if the packet os overfragmented but we do not succeed to allocate extra pages.

kostyanf14 commented 2 months ago

@ybendito @YanVugenfirer Please ignore Static Tools Logo Test, this is a CI issue.

ybendito commented 2 months ago

We have an ack from QE

ybendito commented 2 months ago

Static logo tools failure: ignored (@kostyanf14 ) NetKVM-Win11_22H2: failed 2c_mini6rsssendrecv. Can't install protocol. As far as I remember this failure should be filtered out (filter 5442). @kostyanf14 Please check. NetKVM-Win2019x64: Failed 1c_OffloadRsc: NdisTest finished ok. WTL file is broken. NetKVM-Win2022: Failed FlitchFreeDevice: "Test adapter received 39% of packets, required 40% to pass", @kostyanf14 Probably we need to increate tx buffer of the tap even more. What is the size now?