search

virtio-win / virtio-win-guest-tools-installer

121 stars 19 forks source link

test #18

Closed Gal-Zaidman closed 3 years ago

Gal-Zaidman commented 3 years ago

Wanted to check if there is CI for this project, there is no CI for the project

YanVugenfirer commented 3 years ago

Wanted to check if there is CI for this project, there is no CI for the project

Any thoughts on what we can test during CI?

Gal-Zaidman commented 3 years ago

Wanted to check if there is CI for this project, there is no CI for the project

Any thoughts on what we can test during CI?

That the build is passing: https://github.com/virtio-win/virtio-win-guest-tools-installer/blob/master/automation/build-artifacts.sh and maybe the unit tests I wrote: https://github.com/virtio-win/virtio-win-guest-tools-installer/blob/master/test/test.py

I haven't worked on the project for a long time but I remembered we had CI for it... not sure why there is no CI since everything is setup (I wrote the project with build artifacts and automation dir like RHV CI needs). At the very least we should try and build it and check that artifacts are created properly. I sent a message to Ehud from RHV CI team to look at the project and check what is needed for CI.

BTW on D/S we have proper CI that builds for each patch... that's why it is weird to me